https://bugzilla.redhat.com/show_bug.cgi?id=744416 --- Comment #11 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Just two questions. See below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3409920 bytes in 72 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ---> Any reason not to create a -doc package? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL", "GPL (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated". 22 files have unknown license. Detailed output of licensecheck in /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/744416-libisofs1/licensecheck.txt ---> Nothing seems problematic. libisofs-1.4.2/libisofs/aaip-os-dummy.c libisofs-1.4.2/libisofs/aaip-os-freebsd.c libisofs-1.4.2/libisofs/aaip-os-linux.c libisofs-1.4.2/libisofs/aaip_0_2.c libisofs-1.4.2/libisofs/aaip_0_2.h libisofs-1.4.2/libisofs/hfsplus_case.c libisofs-1.4.2/libisofs/libiso_msgs.c libisofs-1.4.2/libisofs/libiso_msgs.h ---> All these are listed under "unknown" by licensecheck. Looking at the source files, all are GPLv2. [x]: License file installed when any subpackage combination is installed. ---> /usr/share/licenses/libisofs1-1.4.2/COPYING [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. ---> Please fix this. Should also include MIT. License: GPLv2+ and LGPLv2+ https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Buildroot is not present Note: Buildroot: present but not needed [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libisofs1-devel , libisofs1-debuginfo ---> Requires: %{name}%{?_isa} = %{version}-%{release}, pkgconfig [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3471360 bytes in /usr/share ---> ---> Any reason not to create a -doc package? [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libisofs1-1.4.2-2.el7.centos.x86_64.rpm libisofs1-devel-1.4.2-2.el7.centos.x86_64.rpm libisofs1-debuginfo-1.4.2-2.el7.centos.x86_64.rpm libisofs1-1.4.2-2.el7.centos.src.rpm libisofs1.x86_64: W: spelling-error %description -l en_US Libisofs -> Libidos libisofs1.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically libisofs1.x86_64: W: spelling-error %description -l en_US multisession -> simulation libisofs1.x86_64: W: spelling-error %description -l en_US xattr -> attract libisofs1.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems libisofs1.x86_64: W: spelling-error %description -l en_US zlib -> lib, glib, z lib libisofs1.x86_64: W: spelling-error %description -l en_US zisofs -> kissoffs libisofs1.x86_64: W: incoherent-version-in-changelog 1.4.2-2 ['1.4.2-2.el7.centos', '1.4.2-2.centos'] libisofs1.x86_64: E: incorrect-fsf-address /usr/share/doc/libisofs1-1.4.2/COPYRIGHT libisofs1.x86_64: E: incorrect-fsf-address /usr/share/licenses/libisofs1-1.4.2/COPYING libisofs1-devel.x86_64: W: only-non-binary-in-usr-lib libisofs1.src: W: spelling-error %description -l en_US Libisofs -> Libidos libisofs1.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically libisofs1.src: W: spelling-error %description -l en_US multisession -> simulation libisofs1.src: W: spelling-error %description -l en_US xattr -> attract libisofs1.src: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems libisofs1.src: W: spelling-error %description -l en_US zlib -> lib, glib, z lib libisofs1.src: W: spelling-error %description -l en_US zisofs -> kissoffs 4 packages and 0 specfiles checked; 2 errors, 16 warnings. ---> None of this is an issue. Rpmlint (debuginfo) ------------------- Checking: libisofs1-debuginfo-1.4.2-2.el7.centos.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- libisofs1-debuginfo.x86_64: W: only-non-binary-in-usr-lib libisofs1.x86_64: W: incoherent-version-in-changelog 1.4.2-2 ['1.4.2-2.el7.centos', '1.4.2-2.centos'] libisofs1.x86_64: E: incorrect-fsf-address /usr/share/doc/libisofs1-1.4.2/COPYRIGHT libisofs1.x86_64: E: incorrect-fsf-address /usr/share/licenses/libisofs1-1.4.2/COPYING 3 packages and 0 specfiles checked; 2 errors, 2 warnings. Requires -------- libisofs1-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libisofs1(x86-64) libisofs1.so.6()(64bit) pkgconfig libisofs1-debuginfo (rpmlib, GLIBC filtered): libisofs1 (rpmlib, GLIBC filtered): /sbin/ldconfig libacl.so.1()(64bit) libacl.so.1(ACL_1.0)(64bit) libc.so.6()(64bit) libpthread.so.0()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) rtld(GNU_HASH) Provides -------- libisofs1-devel: libisofs1-devel libisofs1-devel(x86-64) pkgconfig(libisofs1-1) libisofs1-debuginfo: libisofs1-debuginfo libisofs1-debuginfo(x86-64) libisofs1: libisofs1 libisofs1(x86-64) libisofs1.so.6()(64bit) libisofs1.so.6(LIBISOFS6)(64bit) Source checksums ---------------- http://files.libburnia-project.org/releases/libisofs-1.4.2.tar.gz : CHECKSUM(SHA256) this package : d5e7f3ea613a78924dde979f699427b1c6b85ba4540d275aa67945b4a70fb3ab CHECKSUM(SHA256) upstream package : d5e7f3ea613a78924dde979f699427b1c6b85ba4540d275aa67945b4a70fb3ab Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m epel-7-x86_64 -b 744416 Buildroot used: epel-7-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx