[Bug 1330856] Review Request: numix-gtk-theme - Numix Gtk Theme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1330856



--- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> ---
> [!]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses
>     found: "Unknown or generated". 18 files have unknown license. Detailed
>     output of licensecheck in /home/slaanesh/1330856-numix-gtk-
>     theme/licensecheck.txt

That's ok, you can ignore it, as long as it's not showing different icons.

> [!]: Changelog in prescribed format.
> numix-gtk-theme.noarch: W: incoherent-version-in-changelog 2.5.1-2 ['2.5.1-2.gitbde0a73.fc23', '2.5.1-2.gitbde0a73']

You should have exactly the same name-version-release tags in the changelog as
the package that you are generating. That is, in this case: 2.5.1-2.gitbde0a73

Please note that actually (next time) when you update the spec file with
"rpmdev-bumpspec" it will actually put the correct tag in the changelog as
required.

> [!]: Requires correct, justified where necessary.

The directory %{_datadir}/themes is not owned by your package, please add
"filesystem" as requirement. It's always installed, but better be safe than
sorry.

$ rpm -qf /usr/share/themes/
filesystem-3.2-37.fc24.x86_64

> numix-gtk-theme.noarch: E: description-line-too-long C Numix is a modern flat theme with a combination of light and dark elements. It supports Gnome, Unity, XFCE and Openbox.

Plase open the text file with an editor and make sure that you have
descriptions cut at 80 columns. As obvious you don't need to have exactly 80
columns but you can just cut before reaching the amount.

> numix-gtk-theme.noarch: E: script-without-shebang /usr/share/themes/Numix/xfwm4/stick-toggled-pressed.xpm

All the files that are under /usr/share/themes should not be executable. Please
run something like this after the %make_install macro:

find %{buildroot} -name "*.xml" -exec chmod 644 {} \;

Or better fix the Makefile. At the end rpmlint should return no
"script-without-shebang" or "spurious-executable-perm".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]