[Bug 1305996] Review Request: python-pyuv - A Python module which provides an interface to libuv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1305996



--- Comment #13 from Athmane Madjoudj <athmanem@xxxxxxxxx> ---
(In reply to William Moreno from comment #12)
> Package Review
> ==============
> 
> 1.
> [!]: Package contains no bundled libraries without FPC exception.
> There is a complete libuv bundled in pyuv-1.2.0/deps/libuv/
> 

Removed, it was not used during the build anyway (system-wide libuv forced
before build steps)

> 2.
> [!]: %check is present and all tests pass.
> Most of the time with python packages try to get some pkgs from pypi in
> check there are missing build requires (and maybe missing requires) please
> doble check if dowloaded packages are already in Fedora repos, if so,
> include then as buildrequires, if not you must package then firt.
> 

Fixed

> 3.
> There is a doc directory than you can compile to html with python-sphinx and
> include in a doc subpackage.
> 

Fixed

> 4.
> Can these files go to a -devel supackage.
> Unversioned so-files
> --------------------
> python2-pyuv: /usr/lib64/python2.7/site-packages/pyuv/_cpyuv.so
> python3-pyuv: /usr/lib64/python3.4/site-packages/pyuv/_cpyuv.cpython-34m.so
> 

so-files are part of the module itself, if moved 'import pyuv' with fail.

Please find updated SPEC/SRPM:


SPEC: https://athmane.fedorapeople.org/pkgs/python-pyuv.spec
SRPM: https://athmane.fedorapeople.org/pkgs/python-pyuv-1.2.0-6.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]