Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Gnome Network Monitor - A Network Monitor for the GNOME Desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239435 ------- Additional Comments From jhrozek@xxxxxxxxxx 2007-06-27 11:12 EST ------- (In reply to comment #8) Thank you for reviewing the package again, hope that everything will be OK this time :) > Bad: > - License file should be includes from tar ball. Fixed, thanks for spotting that. > - BR on gettext-devel may be better, because gettext-devel comtains > development tools which are not in the gettext package. Why? I don't use anything from gettext-devel..remember, this is a python package. What exactly would be better if I included gettext-devel even though the package builds fine in mock chroot? > - Wrong Requires: > You use: > Requires(post): /usr/bin/update-desktop-database > Requires(postun): /usr/bin/update-desktop-database Removed as spurious. Wrt your last comment and http://fedoraproject.org/wiki/PackagingDrafts/DesktopFiles I guess that only BuildRequires: desktop-file-install is needed. > - Package does not sure the ownership of the directory > %{python_sitelib}/%{name}/ > > The best way to make sure, that the directory and all files belong to the > package is to write > > %{python_sitelib}/%{name}/ > Thank you, fixed. > > - Desktop entry contains no icon. > I'm not sure what exactly do you mean...you don't see an icon in the menu? I just double checked in a vanilla F7 vmware install that I _can_ see the icon after installing the package..but I could reproduce the problem on another box with KDE as the only DE..I'm not entirely sure what the problem might be... New packages located at: http://gnetworkmonitor.sourceforge.net/rpm/gnome-network-monitor-0.9.1-5.fc8.src.rpm http://gnetworkmonitor.sourceforge.net/rpm/gnome-network-monitor.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review