Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtextcat - language guessing library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245917 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-06-27 09:51 EST ------- Some remarks: * The tarball is mis-packaged: # rpmbuild -ba libtextcat.spec ... .../rpms/BUILD/libtextcat-2.2/missing: Unknown `--run' option ... You might want to patch it (Better: Upstream should use "make dist" to build the tarball) * The *devel package doesn't contain headers: # rpm -qlp libtextcat-devel-2.2-1.fc7.i386.rpm /usr/bin/createfp /usr/lib/libtextcat.so -> libtextcat.so.0.0.0 I don't know how this package is supposed to be used, but IMO, a devel package without headers doesn't make much sense. * The configuration plays nasty tricks with CFLAGS (-g -O3 -funroll-loops). Fortunately, they don't have much impact in this case. Otherwise, this package looks good. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review