https://bugzilla.redhat.com/show_bug.cgi?id=1264715 Jiri Eischmann <jeischma@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeischma@xxxxxxxxxx --- Comment #3 from Jiri Eischmann <jeischma@xxxxxxxxxx> --- Unfortunately, I have not been able to run fedora-review on it in F24 for some reason. So for the start: 1) current: BuildRequires: %{_bindir}/desktop-file-validate correct: BuildRequires: desktop-file-utils 2) current: BuildRequires: gcc-c++ cmake correct: BuildRequires: cmake gcc-c++ doesn't have to be specifically required 3) mkdir build should go to the %build section 4) I consulted the %build and %install sections with Jan Grulich who maintains quite a few Qt apps in Fedora, it should be like this according to him: %build mkdir -p %{_target_platform} pushd %{_target_platform} %{cmake} \ -DBUILD_TESTS=Yes \ -DUSE_QT5=Yes \ .. popd make %{?_smp_mflags} -C %{_target_platform} %install make install DESTDIR=%{buildroot} -C %{_target_platform} %find_lang %{name} --with-qt 5) There is no need to specify a full path, so it should rather be: %post update-desktop-database &> /dev/null || touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun update-desktop-database &> /dev/null || if [ $1 -eq 0 ] ; then touch --no-create %{_datadir}/icons/hicolor &>/dev/null gtk-update-icon-cache -f %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans gtk-update-icon-cache -f %{_datadir}/icons/hicolor &>/dev/null || : 6) Desktop file validation should be in the %check section 7) It's a desktop app, so it needs to have an AppData metadata file to appear in the app catalog. There also needs to be a validation check: https://fedoraproject.org/wiki/Packaging:AppData I can help you create the metadata file. 8) Commands don't have to be indented, it's rather rare to see in spec files, but it's just formality. 9) It fails the upstream tests because the test is specifically looking for ffmpeg which is not available in Fedora for legal reasons. But I tried and Falcon doesn't depend on it, it's still useful and can do the job with free music formats, so I would just ignore the tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx