[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #54 from paul.j.reger@xxxxxxxxx ---
(In reply to Michal Schmidt from comment #51)
> So after doing "git clean -fdx && ./makesrpm.sh" I got
> libpsm2-10.1.4-1.fc24.src.rpm
> 
> Inside it there is libpsm2-10.1.4.tar.gz (that makesrpm.sh generated using
> "make dist") and a spec file libpsm2.spec.
> The spec file's URL tag currently points to a non-existent file, because the
> latest uploaded tarball on github is for 10.1.2.
> You can fix it by one of the following ways:
>  1. Publish the 10.1.4 tarball on github to make the Source0 URL valid, or
> 
>  2. stop trying to publish the tarballs on github and instead change the spec
>    file to say:
> 
>    # The tarball can be created by:
>    # git clone https://github.com/01org/opa-psm2
>    # cd opa-psm
>    # git checkout 8f9f240380ae
>    # make dist
>    Source0: %{name}-%{version}.tar.gz
> 
> I'd choose option 1 for actual stable releases. Option 2 is good for
> packaging arbitrary git snapshots.
> 

For reasons too complicated to explain here, we decided to go with the 2nd of
the two ways you indicate above.

FIXED and pushed to github.

> I have not run fedora-review on this yet, so for now let's only point out
> minor issues inside the spec:

Can you please run fedora-review soon?  I request that we expedite this review,
and if I am given all of the problems at once, I can probably fix them all in
shorter time than waiting for new batches of problems.

> The directory %{_libdir}/psm2-compat appears unowned.

FIXED and pushed to gitbub.

> > %{__make} DESTDIR=$RPM_BUILD_ROOT install
> There is a macro for this:
> %make_install
> (Note: It's different from %makeinstall, which should be avoided.)

FIXED and pushed to github.

> > /usr/lib/modprobe.d/libpsm2-compat.conf
> This thing does not have a dedicated macro, but at least use a macro for
> /usr:
> %{_prefix}/lib/modprobe.d/libpsm2-compat.conf

FIXED and pushed to github.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]