[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #50 from paul.j.reger@xxxxxxxxx ---
(In reply to Michal Schmidt from comment #49)
> (In reply to paul.j.reger from comment #48)
> > On a Fedora system:
> > Pull the 10.1 branch from github to a sandbox.
> > cd sandbox
> > ./makesrpm.sh
> > [...]
> > The source rpm is in temp.3182/SRPMS/libpsm2-10.1.3-1.fc23.src.rpm
> 
> When I do the above steps, the resulting file is called
> libpsm2-0.7.18-1.fc24.src.rpm.
> 
> This raises several questions:
> 1. Have you decided to call the tarballs and packages "libpsm2"? I see this
>    change was done only on the "10.1" branch, while "master" uses the name
>    "hfi1-psm". Which one is the intended name going forward?

The 'root name' of the package has been changed from 'hfi1-psm' to 'libpsm2'
for the 10.1 branch just last week.

The plan going forward is the 10.1 branch will be merged to master once:

a) we have finished development of 10.1
b) our validation group has tested it.
c) we have fixed all bugs found by our validation group.
d) our validation group cannot find any more bugs in it.
e) management approves the release of this code.

We expect a-e to take about 8 weeks.

Our current work reviewing the spec file processing is critical to developing
the 10.1 release.

> 2. Why am I getting "0.7.18" instead of "10.1.3" like you? Is the github repo
>    missing some git tags?

Yes, I forgot to push one git tag named v10.1.  Sorry about that.  I fixed that
just now.  I pushed a tag called v10.1 to the github repo.

> 3. You said version 10.1 is being worked on and will take a few weeks to get
>    done. If today's version is "10.1.3", how are you going to ensure version
>    monotonicity?

The '3' in the version 10.1.3 corresponds to the ordinal commit since the most
recent tag.  The most recent tag is v10.1, and as of April 25, 2016 at 3:30 PM,
there have been 4 commits.  So, the current src rpm is named:

The source rpm is in temp.20704/SRPMS/libpsm2-10.1.4-1.src.rpm

Note that the version is computed in the Makefile based on a lot of factors.

>    When you do the actual release of 10.1 in a few weeks, is
>    its precise version going to be 10.1.<n> where n > 3 ?

Yes.  I cannot predict the value of n as the changes have not been completely
sorted out yet.

Did you review the spec file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]