Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SteGUI - SteGUI is a graphical front-end to Steghide https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244171 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora ------- Additional Comments From bugs.michael@xxxxxxx 2007-06-27 07:58 EST ------- Just a brief look at the spec, not at the src.rpm: > Name: SteGUI > Summary: SteGUI is a graphical front-end to Steghide > Summary(fr): SteGUI est un interface graphique pour Steghide Repeating the package/software name in the summary is considered bad taste often, since in many package database interfaces it usually results in displaying the package %{name} multiple times, e.g.: SteGUI - SteGUI is a graphical front-end to Steghide > Requires: fltk A dependency on the fltk shared libs is automatically added by rpmbuild. If not, then your package doesn't link against fltk actually, and in that case you should add a comment in the spec file as why it requires fltk. > %install Below this you're missing: rm -rf $RPM_BUILD_ROOT > strip -s $RPM_BUILD_ROOT%{_bindir}/%{name} Don't strip binaries, since that makes the -debuginfo packages useless. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review