[Bug 1329188] Review Request: nvml - Non-Volatile Memory Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1329188



--- Comment #6 from Dan Williams <dan.j.williams@xxxxxxxxx> ---
(In reply to Krzysztof Czurylo from comment #5)
> 1) The scripts are part of library installation/de-installation process and
> they update the magic(5) files used by file(1) command, allowing to identify
> the type of pmem* pool files based on the signature stored in the pool
> header.
> I don't know any better way to update /etc/magic file.

Send patches to update the upstream file(1).  Unless / until there is an
/etc/magic.d directory where nvml could drop it's own configuration file, it is
discouraged to live edit a system's local configuration file.

> 2) Currently, only x86_64 architecture is supported.  This is because in
> libpmem we use some Intel-specific CPU instructions (inline assembly +
> xmmintrin.h).

Can those optimized routines be swapped out for slower POSIX calls or omitted
entirely on non-x86_64 builds?  That would save you from having to go file bugs
to track unsupported archs per the guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]