[Bug 1327994] Re-Review Request: python-jupyter-core - Jupyter core package. A base package on which Jupyter projects rely

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1327994

Jonathan Underwood <jonathan.underwood@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #20 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> ---
OK, great. Obsoletes and Provides are sane and correct. All other problems
fixed, so this is ready to go. Thanks for working on this. APPROVED.

Regarding this:

(In reply to Thomas Spura from comment #18)
> > python3-jupyter-core.noarch: E: python-bytecode-wrong-magic-value
> > /usr/lib/python3.5/site-packages/jupyter_core/paths.pyc expected 3350 (3.5),
> > found 62211 (2.7)
> > python3-jupyter-core.noarch: E: python-bytecode-wrong-magic-value
> > /usr/lib/python3.5/site-packages/jupyter_core/__init__.pyc expected 3350
> > (3.5), found 62211 (2.7)
> > python3-jupyter-core.noarch: E: python-bytecode-wrong-magic-value
> > /usr/lib/python3.5/site-packages/jupyter_core/version.pyc expected 3350
> > (3.5), found 62211 (2.7)
> > 
> > 
> > These look very worrying, suggests the wrong pyton interpreter has
> > been used for their generation?
> 
> It seems %py2_build and %py3_build builds (and compiles) in ./build/ and
> python3 installs the pyc files, generated from python2.
> Workaround at the beginning of %install:
> find | grep pyc$ | xargs rm -v
> 
> This needs proper fixing in distutils...

Have you filed a bug for that somewhere? It seems like this could be affecting
a lot of packages in Fedora.

In the meantime, wouldn't it be a good idea for %py2_install and %py3_install
to remove all pyc as their first action - after all bython byte compilation is
done on the installed files automatically anyway. I'll file a bug against the
pthon macros package, unless you beat me to it :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]