Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: stardict-dic-en - English(en) dictionaries for StarDict https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245878 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-06-27 02:05 EST ------- Here _datadir seems to be used correctly. Another remark: This is pretty clumsy: %prep if [ ! -d %{name}-%{version} ]; then mkdir %{name}-%{version}; fi %setup -q -n %{name}-%{version} -D -T -a 0 It can be written much shorter: %prep %setup -q -c -a 0 [rsp. .... -a 0 -a 1 ... -a N, for packages consisting of more tarballs.] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review