[Bug 1319289] Review Request: rubygem-review - Flexible document format/conversion system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1319289



--- Comment #6 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to Mukundan Ragavan from comment #5)
> 
> 
> There is one mistake in the spec file. You are installing the license file
> and immediately excluding it.
> 
> %license %{gem_instdir}/COPYING
> 
> <snip>
> 
> %exclude %{gem_instdir}/COPYING
> 
> Why?
> 
> 
> I got rid of the exclude line and built a package. See the difference in
> files here - 
> 
> $ diff -Nu w_excld wo_excld
> --- w_excld	2016-04-20 18:58:21.183113956 -0400
> +++ wo_excld	2016-04-20 18:57:55.818377962 -0400
> @@ -11,6 +11,7 @@
>  /usr/bin/review-validate
>  /usr/bin/review-vol
>  /usr/share/gems/gems/review-1.7.2
> +/usr/share/gems/gems/review-1.7.2/COPYING
>  /usr/share/gems/gems/review-1.7.2/ChangeLog
>  /usr/share/gems/gems/review-1.7.2/Dockerfile
>  /usr/share/gems/gems/review-1.7.2/Gemfile
> 
> 
> wo_excld - package build without the exclude lien
> w_excld - package build with the spec linked here.

Failed attempt to not list same file two times.

> 
> 
> -doc package will have no difference. Please fix this.
> 

Sorry, I miss it.
Fix what?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]