https://bugzilla.redhat.com/show_bug.cgi?id=1307228 --- Comment #4 from Adrien Devresse <adev88@xxxxxxxxx> --- Hi Andrea, little informal review : - Please remove the Obsolete, they should be avoided for new packages if not strictly required. - BuildRequires: lfc-libs >= 1.8.8 -> lfc-devel should normally already install lfc-libs -> same for python -> package need to support SystemD for EPEL7 / rawhide This means -> no rsyslog and lograte dependency for these platforms -> Following this guidelines https://fedoraproject.org/wiki/Packaging:Systemd about restart conditions and scriptlets -> Do you really want to support EL5 ? If not, the header concerning boost is not needed. Adrien -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx