https://bugzilla.redhat.com/show_bug.cgi?id=1328390 Honggang LI <honli@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(honli@xxxxxxxxxx) | --- Comment #4 from Honggang LI <honli@xxxxxxxxxx> --- (In reply to Neil Horman from comment #2) > [! ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "BSD (4 clause)", "zlib/libpng", "*No > copyright* BSD (3 clause)", "BSD (3 clause)", "BSD (2 clause)". 130 > files have unknown license. Detailed output of licensecheck in > /home/nhorman/1328390-infinipath-psm/licensecheck.txt > <NH> Needs to be BSD _and_ GPLv2 No, I don't think so. The COPYING file says: ------- COPYING ------ This software is available to you under a choice of one of two licenses. You may choose to be licensed under the terms of the the OpenIB.org BSD license or the GNU General Public License (GPL) Version 2, both included below. ------- COPYING ------ > [!]: %build honors applicable compiler flags or justifies otherwise. > <NH> NEED to include the rpm build opts macro Added "export CFLAGS="$RPM_OPT_FLAGS"". > [!]: Package contains no bundled libraries without FPC exception. > <NH> > this package builds its own UUID library. Shouldn't do that, opting instead > to > BuildRequire: libuuid-devel and link against the libuuid package libraries > Its own UUID had been removed and PSM_USE_SYS_UUID=1 had been setup too. It is no longer an issue. > [!]: Package does not generate any conflict. > <NH> I don't think that you need to specify both Obsoletes and Conflicts in > spec > Removed duplicated Cnflicts tags. > [!]: Requires correct, justified where necessary. > <NH> Should add libuuid No need. As rpm tools will take care it for us. > [!]: Package functions as described. > <NH> Can't test this, have you verified? Yes, it works as expected. > [!]: SourceX tarball generation or download is documented. > Note: Package contains tarball without URL, check comments > It would be perferable to use the tagged release URL to get the pristine > sources, to prevent inadvertent changes to the md5sum Upstream maintainer told me to create the tag ball by run 'make dist'. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx