[Bug 1327176] Review Request: fabtests - Test suite for libfabric API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1327176



--- Comment #7 from Michal Schmidt <mschmidt@xxxxxxxxxx> ---
Created attachment 1148539
  --> https://bugzilla.redhat.com/attachment.cgi?id=1148539&action=edit
[PATCH] adjust shebang lines in rft_yaml_to_junit_xml and runfabtests.sh

> Requires: ruby

I'm not sure that's even the correct package name to require. /usr/bin/ruby is
provided by a package called "rubypick", which in turn pulls in one of the Ruby
implementations.

I think a better way to get the dependencies right is to patch the scripts to
avoid using /usr/bin/env in shebang lines ("#!/usr/bin/env bash" looks
particularly silly, but I understand upstream tries wants to be compatible with
non-Linux systems). Then rpmbuild will be able to record the dependency on the
script interpreter and you won't have to have an explicit Requires.

Suggested patch to apply as %patch1 attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]