https://bugzilla.redhat.com/show_bug.cgi?id=1149566 --- Comment #29 from Adam Huffman <bloch@xxxxxxxxxxxx> --- Hi David, It's certainly acceptable to include patches in the RPM to fix these errors, while also submitting them upstream. Here are a couple of things highlighted by fedora-review: - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9400320 bytes in 234 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation Cheers, Adam -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx