[Bug 1264654] Review Request: php-aws-sdk3 - Amazon Web Services framework for PHP (3.x)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1264654



--- Comment #11 from Shawn Iwinski <shawn@xxxxxxxx> ---
THANKS for the review!  SCM requests opened via pkgdb.



(In reply to Remi Collet from comment #10)
> you may want to switch autoloader without @include_once.

I will make this fix after initial import.



(In reply to Remi Collet from comment #10)
> [~]: %check is present and all tests pass.
> 	OK with PHP 5.6.20
> 	OK with PHP 7.0.6RC1
> 	=> some failure during fedora-review
> 	   mays need to increase memory-limit (1G seems enough)

I will modify the memory limit in the tests after initial import



> [~]: Requires correct, justified where necessary.
> 	May want to drop Conflicts
> 
> 	php-doctrine-cache < 1.4.1 don't have the autoloader so no issue
> 	php-doctrine-cache >= 2 when exists will probably be php-doctrine-cache2
> 	php-aws-php-sns-message-validator < 1 doesn't exists
> 	php-aws-php-sns-message-validator >= 2 will probably be
> php-aws-php-sns-message-validator2
> 	See PHP-SIG discussion.

We'll discuss in PHP-SIG mailing group.



> I have to run fedora-review against an altered spec file
> 
> -%{_bindir}/phpunit --verbose --bootstrap bootstrap.php
> +%{_bindir}/phpunit -d memory_limit=1G --verbose --bootstrap bootstrap.php
> 
> But, as scratch build succeeds I won't consider this as a blocker.
> 
> Some comments but no blocker, as the package complies to the Packaging
> Guidelines:
> 
> === APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]