Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: crystal-project - KDE Icon set https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245151 ------- Additional Comments From maxime@xxxxxxxxxx 2007-06-26 17:30 EST ------- Review : MUST : name : OK MUST : macros (%{name}, %{version}) : OK MUST : licence : (LGPL) OK (chitlesh told me he asked the upstream to include the text in the source) MUST : source match the upstream source (MD5 sum match) MUST : dependencies : OK MUST : owns directory : OK MUST : %defattr : OK MUST : rm -rf %{buildroot} in %install and %clean section: OK MUST : RpmLint is NOT quiet : W: crystal-project dangling-relative-symlink /usr/share/icons/crystal_project/16x16/apps/kmenu.png ../../../Bluecurve/16x16/apps/gnome-main-menu.png W: crystal-project dangling-relative-symlink /usr/share/icons/crystal_project/22x22/apps/kmenu.png ../../../Bluecurve/24x24/apps/gnome-main-menu.png W: crystal-project dangling-relative-symlink /usr/share/icons/crystal_project/32x32/apps/kmenu.png ../../../Bluecurve/32x32/apps/gnome-main-menu.png W: crystal-project dangling-relative-symlink /usr/share/icons/crystal_project/48x48/apps/kmenu.png ../../../Bluecurve/48x48/apps/gnome-main-menu.png =>That's OK since fedora-logos is a dependency. This is OK for me : approved -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review