https://bugzilla.redhat.com/show_bug.cgi?id=1327994 --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > Created attachment 1148257 [details] > tweaks to the spec file > > I wanted to try the review of python-jupyter-client, so I needed this to > build :) > > The fix for the missing module is simple enough (add PYTHONPATH). > > I also modified the installation procedure to link jupyter → jupyter-2 → > jupyter-2.7, jupyter-3 → jupyter-3.5 (with cp one of those symlinks would be > real files instead) > > Also %license. Thanks for the fixes! > Some more things I'd change: > > I think the package should be renamed to python-jupyter-core. "use dashes in > preference to underscores." > [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming]. Fixed. Only did it in %name so far... Thanks for pointing it out! > Summary should not repeat the package name, and should not be a sentence. > And the %description could be extended to say what this package actually > does. New urls: Spec URL: https://tomspur.fedorapeople.org/review/python-jupyter-core/python-jupyter-core.spec SRPM URL: https://tomspur.fedorapeople.org/review/python-jupyter-core/python-jupyter-core-4.1.0-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx