https://bugzilla.redhat.com/show_bug.cgi?id=1327989 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Also here, "use dashes in preference to underscores." [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming]. It currently fails because of the -/_ mismatch with core: Error: nothing provides python3-jupyter-core needed by python3-jupyter_client-4.2.2-1.fc23.noarch. /usr/bin/jupyter-kernelspec-3 should be a symlink to jupyter-kernelspec-3.x. /usr/bin/jupyter-kernelspec-2 should be a symlink to jupyter-kernelspec-2.x. /usr/bin/jupyter-kernelspec should be a symlink to jupyter-kernelspec-2 or jupyter-kernelspec-3. (In particular the symlinks should not specify the full path. It makes a difference for example in containers and chroots. Also it makes more sense to link to the more specific from the more generic, hence -2 → -2.7, not the other way around.) Use %license. Looks good otherwise. Would it be possible to switch to python3 as default (for the whole jupyter stack)? After all it's a new set of package, so now might be a good moment to do the switch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx