https://bugzilla.redhat.com/show_bug.cgi?id=1314974 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #17 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. moved knode-libs icons to main pkg, BuildRequires exceptions are no longer present in guidelines, update-desktop-database scriptlets already included (%postun and %posttrans) 2. dbus dirs owned by dbus, knode-libs now owns %{_kde4_libdir}/kde4/plugins/accessible/ 3. Should be better to exclude this file: knode.x86_64: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/apps/knode.svgz This is fairly common for kde applications. 4. This package ships many subpackages and I am curious about than there is not any devel subpackage. many? There's only 3: knode, knode-libs, ktimetracker. There's no -devel because it doesn't ship anything development related (no header files for use elsewhere) 5. Subpackages do not have a license text in the rpm: fixed 6. Some of this files can be moved to a common subpackage? Could consider that, but I'd rather not introduce the greater packaging complexity (the savings here isn't compelling enough). 7. Upstream link to sources is not working: fixed Spec URL: https://rdieter.fedorapeople.org/rpms/kdepim4/kdepim4.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kdepim4/kdepim4-4.14.10-23.fc24.src.rpm %changelog * Sat Apr 16 2016 Rex Dieter <rdieter@xxxxxxxxxxxxxxxxx> - 4.14.10-23 - knode: move icons in -libs to main pkg - knode-libs: own %%{_kde4_libdir}/kde4/plugins/accessible/ - add %%license files - update URL, Source URL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx