https://bugzilla.redhat.com/show_bug.cgi?id=1321455 Tomas Hozza <thozza@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(thozza@xxxxxxxxxx | |) | --- Comment #3 from Tomas Hozza <thozza@xxxxxxxxxx> --- (In reply to Jan Včelák from comment #2) > Thank you. Updated. > > Spec URL: > https://jvcelak.fedorapeople.org/review/knot-resolver/1.0.0-0.2.79a8440/knot- > resolver.spec > SRPM URL: > https://jvcelak.fedorapeople.org/review/knot-resolver/1.0.0-0.2.79a8440/knot- > resolver-1.0.0-0.2.79a8440.fc23.src.rpm > > > (In reply to Tomas Hozza from comment #1) > > - Package does not contain duplicates in %files. > > Note: warning: File listed twice: /var/lib/kresd/root.keys > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > > Fixed. > > > - Packages should try to preserve timestamps of original installed > > files. > > Fixed. > > > - Files outside of /usr SHOULD be owned by root:root > > (https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions) > > I've changed UID to root where possible. And kept GID to kresd where > necessary. Files inside /var/lib are state information and have to be > writable by the daemon. > > > - Fully versioned dependency in subpackages if applicable. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in knot- > > resolver-devel > > Fixed. > > > - Once you resolve issues with building the documentation, please package is > > as well, because currently there is no man page for the daemon. > > The documentation building can't be fixed easily. The RTD theme cannot be > loaded by Python 2 Sphinx on Fedora, and Breathe is incompatible with Python > 3. > > I've updated the package to current git master because some of the building > issues were resolved. The manual page is now installed. And unit tests > results are temporarily ignored (one failure is present and should be fixed > in the gold release). Thank you for resolving the issues. The package is APPROVED for Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx