https://bugzilla.redhat.com/show_bug.cgi?id=1297347 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@xxxxxxxxx --- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> --- The spec file is full of useless and dangerous things: - useless: already added by maven-local. please remove BuildRequires: java-devel >= 1:1.8 Requires: java-headless >= 1:1.8 NO more necessary. please remove Group: Documentation %check (is NOT necessary. please remove) please, use %files javadoc -f .mfiles-javadoc %license texts/LICENSE-2.0.txt instead of %files javadoc %license texts/LICENSE-2.0.txt %doc %{_javadocdir}/%{name} (is NOT necessary. please remove) This: %setup -c -q mv -f %{name}-%{version}/* . for me does not make sense, at least I can not explain it - dangerous: BuildRequires: maven-shade-plugin is not safe introduce copy of system libraries into this or other artifact for example if one of these have a "security problems". the maintainer work would be compromised and the problem remain if this package is not rebuilt every time a dependency is updated -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx