https://bugzilla.redhat.com/show_bug.cgi?id=1327083 Michal Schmidt <mschmidt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- > # Add -fsigned-char to build it on ARM platform. > export CFLAGS="$RPM_OPT_FLAGS -fsigned-char" This is because of this code: char c; /* ... */ while ((c = getopt(argc, argv, "bd:")) != EOF) { /* ... */ } A better fix is to have 'c' as int. Also, getopt() is specified to return -1, not EOF, when all options have been parsed. On glibc EOF is -1, but it should not be relied on. I'm not going to block the review for this, but please have this fixed upstream. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx