https://bugzilla.redhat.com/show_bug.cgi?id=1321825 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + name is OK + license is OK (PSF) + license file is present, %license is used + python packaging macros are used + provides/requires look sane + %python_provide is used + no scriptlets present or necessary + builds and install OK Package is APPROVED. Comments: I'd add: %global _description \ Provides support for quantities and units, ... %description %_description %description -n python2-%{modname} %_description %description -n python3-%{modname} %_description I don't think deleting tests is proper. Quite often you want to run the tests on the target system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx