[Bug 1302904] Review Request: cacti - re-review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1302904



--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
If possible, it would be better to use the system wide jquery package. If not
possible, add Provides for bundled jquery
[https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries].

Those should not be executable:
-rwxr-xr-x 
/usr/share/cacti/include/js/images/ui-bg_diagonals-thick_18_b81900_40x40.png
-rwxr-xr-x 
/usr/share/cacti/include/js/images/ui-bg_diagonals-thick_20_666666_40x40.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-bg_flat_10_000000_40x100.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-bg_glass_100_f6f6f6_1x400.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-bg_glass_100_fdf5ce_1x400.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-bg_glass_65_ffffff_1x400.png
-rwxr-xr-x 
/usr/share/cacti/include/js/images/ui-bg_gloss-wave_35_f6a828_500x100.png
-rwxr-xr-x 
/usr/share/cacti/include/js/images/ui-bg_highlight-soft_100_eeeeee_1x100.png
-rwxr-xr-x 
/usr/share/cacti/include/js/images/ui-bg_highlight-soft_75_ffe45c_1x100.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-icons_222222_256x240.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-icons_228ef1_256x240.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-icons_ef8c08_256x240.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-icons_ffd27a_256x240.png
-rwxr-xr-x  /usr/share/cacti/include/js/images/ui-icons_ffffff_256x240.png

You missed my comment about systemd requirements. You need to add:
BR: systemd
%{systemd_requires}

... in fact even rpmlint warns about this:
cacti.noarch: W: percent-in-%post
cacti.noarch: W: percent-in-%postun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]