[Bug 1327083] Review Request: usnic-tools - Simple tool for extracting diagnostics and informational data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1327083



--- Comment #1 from Michal Schmidt <mschmidt@xxxxxxxxxx> ---
> Name:           usnic-tools
> Version:        1.1.0.0
> Release:        1%{?dist}
> Summary:        Simple tool for extracting diagnostics and informational data

One could match that summary on a lot of packages :-)
How about:
Tool for extracting diagnostics and informational data from Cisco usNIC devices

> License:        GPLv2 or BSD
> Url:            http://cisco.com/

Please use a more relevant URL. https://github.com/cisco/usnic_tools

> Source0:        https://github.com/cisco/usnic_tools/releases/download/v%{version}/%{name}-%{version}.tar.gz
> BuildRequires:  libfabric-devel >= 1.3.0
> 
> %description
> This is a simple tool for extracting some diagnostics and informational
> meta data out of Cisco usNIC devices using the Cisco usNIC extensions
> in libfabric.
> 
> %prep
> %setup -q
> 
> %build
> %configure
> make %{?_smp_mflags}
> 
> %install
> %{make_install}
> 
> %files
> # All files are licensed in GPLv2.

Misleading. Remove the comment.

> %{_bindir}/*
> %license COPYING

Might want to add %doc README.md, even though most of its content is irrelevant
build instructions. The example output is nice to have.

> %changelog
> * Thu Apr 14 2016 Honggang Li <honli@xxxxxxxxxx> - 1.1.0.0-1
> - Import usnic-tools for Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]