https://bugzilla.redhat.com/show_bug.cgi?id=1326170 Shawn Iwinski <shawn@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(shawn@xxxxxxxx) | --- Comment #5 from Shawn Iwinski <shawn@xxxxxxxx> --- (In reply to Remi Collet from comment #4) > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/share/php/Aws/Sns(php- > aws-sdk), /usr/share/php/Aws(php-aws-sdk), > /usr/share/php/Aws/Sns/Exception(php-aws-sdk) > > Despite both provide the same dir, there is no conflicts in provided files > As this library is a new dep of aws sdk v3, perhaps better to move in the > same tree (/usr/share/php/Aws3) > > I fine to approve the package like this, just wait for your idea about the > possible file conflicts if content of php-aws-sdk or this library change in > a future version. > > Changing dir will imply using $fedoraPsr4ClassLoader (shared with > php-aws-sdk), but as "Aws\Sns" is a sub namespace of "Aws" perhaps not > wanted... I much prefer "/usr/share/php/Aws" for this library. There are no current naming conflicts, but I opened https://github.com/aws/aws-php-sns-message-validator/issues/12 asking upstream to guarantee no naming clashes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx