https://bugzilla.redhat.com/show_bug.cgi?id=1326151 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- $ rpmlint *.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. naming: ok sources: ok 8d7bf07a669a2884a409a7b03f89be5c xfce4-calculator-plugin-0.5.1.tar.bz2 licensing: GPLv2 (current) is mostly OK, but all the source code headers also include: ... either version 2 of the License, or * (at your option) any later version. 1. SHOULD update license to License: GPLv2+ macros: ok scriptlets: ok (icons) 2. SHOULD review if this is needed BuildRequires: xorg-x11-server-devel (as far as I can tell, it is not) dir/file ownership: ok APPROVED. Consider reviewing the 2 non-blocker SHOULD items. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx