[Bug 1128480] Review Request: pipsi - Wraps pip and virtualenv to install scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1128480



--- Comment #14 from Petr Viktorin <pviktori@xxxxxxxxxx> ---
I still think the py3-virtualenv change would be better done (more readable)
with a patch than with sed, but it's OK as it is.

This part:
    mkdir -p %{getenv:HOME}/.local/venvs
    mkdir -p %{getenv:HOME}/.local/bin
can create directories outside %{_buildroot}, which is against packaging
guidelines [0]. Plus I'm confused about how exactly these commands are solving
the problem.


[0]
https://fedoraproject.org/wiki/Packaging:Guidelines#Scriplets_are_only_allowed_to_write_in_certain_directories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]