[Bug 1323181] Review Request: python-docker-squash - Docker layer squashing tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1323181



--- Comment #6 from Marek Goldmann <mgoldman@xxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> Please see the attached spec file. It simplifies stuff quite a bit by using
> the macros from
> https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file.

That indeed looks nicer, thanks for helping me out! I've build it on all
targets and it seems to work, cool.

> I also looked at the effect of 2to3 translation, and it's just one change
> (iteritems() → items()). It's much nicer to use a single source without 2to3
> translation, and py3dir, so I replaced that with a sed invocation. I think
> you should file that as a patch upstream.

This basically should be untouched. This is monkey patch for Python 2 only to
enable UTF8 names in PAX headers in tar archives. See:
https://bugzilla.redhat.com/show_bug.cgi?id=1194473

> The spec file required one more major change: python2 subpackage must be
> added according to the new guidelines
> [https://fedoraproject.org/wiki/Packaging:Python].

Awesome, thanks for doing it!

I additionally upgraded to RC4 and here are new files:

Spec URL:
https://goldmann.fedorapeople.org/package_review/python-docker-squash.spec
SRPM URL:
https://goldmann.fedorapeople.org/package_review/python-docker-squash-1.0.0-0.5.rc4.fc23.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13643225

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]