https://bugzilla.redhat.com/show_bug.cgi?id=1302904 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- So..., the same for %{__cp}, %{__mv}, %{__chmod} [See https://fedoraproject.org/wiki/Packaging:Guidelines#Macros]. You can just call useradd too, /usr/sbin is nowawadays in the $PATH even for normal users. BR: systemd %{systemd_requires} Your package reloads httpd.service. This is OK, but then you shouldn't call %systemd_post. This is used to preset (apply default enablement) to a service. For httpd.service this should only be done by the package that installs it. OTOH, you also need to reload httpd.service after installing your package, i.e. in %post: %post if [ $1 -eq 1 ] ; then %systemd_postun_with_restart httpd.service fi The spec file must specify licensing breakdown [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios]. Why do you need %patch0 if you have %autosetup? %autosetup should do patching automatically. Shouldn't /var/log/cacti/cacti.log be %ghost? %description should be wrapped to 80 columns. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx