[Bug 1149566] Review Request: slurm - Simple LinUx Resource Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1149566



--- Comment #21 from Adam Huffman <bloch@xxxxxxxxxxxx> ---
Hi David,

Thanks for the update.

First observation is about the build part.

I and someone on the mailing list found that the following in %build fixed the
FORTIFY warnings during compilation:

#Fix for build and linking failure
CFLAGS="$RPM_OPT_FLAGS -Wl,-z,lazy"
CXXFLAGS="$RPM_OPT_FLAGS -Wl,-z,lazy"

export CFLAGS
export CXXFLAGS

I see you've taken a different approach, which is fine, but your version still
has the build warnings, which I'd prefer to be fixed before inclusion in
Fedora.

Cheers,
Adam

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]