https://bugzilla.redhat.com/show_bug.cgi?id=1322846 --- Comment #9 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Mukundan Ragavan from comment #6) > My complaints - > > 1/ > > [?]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 706560 bytes in 2 files. > > ---> Might I suggest a change here? Please consider moving the license file > to the main package and change the -common subpackage to -doc. I think that > makes the arrangement better. > > If you change it to a -doc subpackage, you will need > Requires:%{name}%{?_isa} = %{version}-%{release} on the sub-packages. > Looking at the spec, I think this is missing already. > > > 2/ > > [?]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > SuperLUMT-double , SuperLUMT-complex , SuperLUMT-complex16 , > SuperLUMT64 , SuperLUMT64-double , SuperLUMT64-complex , > SuperLUMT64-complex16 , SuperLUMT64-devel , SuperLUMT-common , > SuperLUMT-debuginfo > > > ---> Please see earlier comment. > > As it stands now, all the sub packages depend on -common and not on the base > pacakge. I think this needs to be changed. If you decide to incorporate the > change I have suggested above, this will also be addressed. I don't agree here. Since every sub-package should work autonomously, I don't think every one needs to depend by a main package; the only common files are License, Readme and PDF file of about 600 Kb in fact. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx