[Bug 1325414] Review Request: pag - Commandline interaction with pagure.io

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1325414

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
To answer the question about naming: it seems that pag is just a CLI, at least
for now, and other project will not be using the python module. If that ever
changes, it is always possible to split out python3-pag and even possibly
python2-pag submodules. So the name 'pag' is appropriate.

I don't think you need this part:
sed -i 's|/usr/bin/python$|/usr/bin/python3|' %{buildroot}/%{_bindir}/pag
setuptools seems to set the header properly on its own.

+ latest version
+ package name is OK
+ license is acceptable (GPLv3+)
+ license file is present, %license is used
+ python packaging macros are used
+ no scriptlets present or necessary

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]