https://bugzilla.redhat.com/show_bug.cgi?id=1202063 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | Summary|Review Request: Classified |Review Request: |ads - Internet messaging |classified-ads - Internet |done right |messaging done right --- Comment #22 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- %make_install includes $DESTDIR: $ rpmbuild --eval %make_install /usr/bin/make install DESTDIR=/home/zbyszek/rpmbuild/BUILDROOT/%{name}-%{version}-%{release}.x86_64 Similarly %make_build is preferred to make %_smp_mflags. You must add install scriptlets for the desktop file: https://fedoraproject.org/wiki/Packaging:Scriptlets#desktop-database, https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache. This is going away soon, but unfortunately it's still required. There should be blank lines between %changelog entries (before any line with "*"). (For example, during mass rebuilds a script will add a changelog entry with a blank line automatically, and it'll look super ugly to have different formatting.) You shouldn't use %define: https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define. And that definition should be moved somewhere to the top of the file (e.g. before %description). I checked the license headers, and the files specify headers of LGPLv2 or later, except for textedit/textedit.*. Those files specify LGPLv2 or LGPLv3+. You could license the result as LGPLv2 or LGPLv3+, but just LGPLv2 is also acceptable. No issue here, just making a note. In the manpage: "users ability" → "user's ability" or "users' ability", and similarly for "users encryption keys". + latest version + license is acceptable (LGPLv2) + license tag matches sources + license file is present, %license is used + builds and installs OK + rpmlint is quiet Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx