https://bugzilla.redhat.com/show_bug.cgi?id=1325469 Marc Deop <marc@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marc@xxxxxxxxxxxx --- Comment #1 from Marc Deop <marc@xxxxxxxxxxxx> --- Not doing an official review but: - License in COPYING file says it's GPLv3 - Any reason to keep this part: # hack to avoid unused-direct-shlib-dependency rpmlint warnings #export LDFLAGS="-Wl,--as-needed %{?__global_ldflags}" ? - Not sure if there is a reason for this but: # disable update notifier applet by default sed -i \ -e 's|X-KDE-PluginInfo-EnabledByDefault=.*|X-KDE-PluginInfo-EnabledByDefault=false|g' \ notifier/plasmoid/metadata.desktop Why changing the default from upstream? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx