https://bugzilla.redhat.com/show_bug.cgi?id=1321013 Scott Williams <vwfoxguru@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vwfoxguru@xxxxxxxxx --- Comment #1 from Scott Williams <vwfoxguru@xxxxxxxxx> --- A good start. Here's my initial comments: The mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/TaskBar@zpydr/ line is unnecessary since other mkdir -p will generate it It is not usual nomenclature to have an '@' in a filesystem path, especially when the @ appears to be your username. It's uncommon to have '@' in a fs path, but it looks like other Gnome extensions use this. I did notice, however, that the extensions generally point back to an upstream URL rather than a username, such as a GitHub account, but I do see an exception in gnome-shell-extension-pidgin, where the username is used instead. I don't see anything in the packaging guidelines against this, but bringing it up to show what other existing gnome extension packages are doing. For the language support, since you just have a few, you should use %find_lang (See https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files ) Otherwise, rpmlint shows no errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx