https://bugzilla.redhat.com/show_bug.cgi?id=1129493 Scott Williams <vwfoxguru@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |redhat-bugzilla@linuxnetz.d | |e, vwfoxguru@xxxxxxxxx Flags| |needinfo?(redhat-bugzilla@l | |inuxnetz.de) --- Comment #1 from Scott Williams <vwfoxguru@xxxxxxxxx> --- Robert, Thanks for your review submission. Here are my notes from what I can see so far: Reviewing your SPEC file: Since this is only for EL7, you should remove all of the Fedora/RHEL mapping globals in the beginning. If you still need globals, just use ones that cover your scope. There are other long obsoleted references in here, such as gaim. There is a also patch referencing RHEL4, which is probably irrelevant for EL7. Your obsoletes: Obsoletes: pidgin <= 2.7.1-1%{?dist} Pidgin is also not in Requires. It looks like you're actually building a replacement for the pidgin package, rather than an add-on? Doing so will conflict with the CentOS repo pidgin package, so you'll need to split out the extras. The Description describes pidgin generally, not what extras are intended to be provided by this package. Your changelog reflects the pidgin packaging history, not -extras specific. Here's the output from rpmlint: pidgin-extras.src: W: spelling-error Summary(en_US) multiprotocol -> multiprocessor pidgin-extras.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk pidgin-extras.src:422: W: unversioned-explicit-obsoletes gaim-devel pidgin-extras.src:466: W: unversioned-explicit-obsoletes gaim-meanwhile pidgin-extras.src:142: W: mixed-use-of-spaces-and-tabs (spaces: line 27, tab: line 142) pidgin-extras.src: E: specfile-error warning: bogus date in %changelog: Tue Aug 06 2009 Warren Togami <wtogami@xxxxxxxxxx> 2.6.0-0.11.20090812 pidgin-extras.src: E: specfile-error warning: bogus date in %changelog: Tue Aug 06 2009 Warren Togami <wtogami@xxxxxxxxxx> 2.6.0-0.10.20090806 pidgin-extras.src: E: specfile-error warning: bogus date in %changelog: Fri May 31 2007 Stu Tomlinson <stu@xxxxxxxxxxxxx> - 2.0.1-2 pidgin-extras.src: E: specfile-error warning: bogus date in %changelog: Mon Jun 08 2004 Warren Togami <wtogami@xxxxxxxxxx> 0.78-7 pidgin-extras.src: E: specfile-error warning: bogus date in %changelog: Fri Apr 15 2004 Warren Togami <wtogami@xxxxxxxxxx> 0.76-6 pidgin-extras.src: E: specfile-error warning: bogus date in %changelog: Fri Apr 14 2004 Warren Togami <wtogami@xxxxxxxxxx> 0.76-5 pidgin-extras.src: E: specfile-error warning: bogus date in %changelog: Wed Nov 25 2003 Christopher Blizzard <blizzard@xxxxxxxxxx> 1:0.74-0 1 packages and 0 specfiles checked; 7 errors, 5 warnings. Any of the "E"'s here absolutely need addressed. If you haven't already, please take a look at https://fedoraproject.org/wiki/Packaging:Guidelines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx