https://bugzilla.redhat.com/show_bug.cgi?id=1316676 --- Comment #6 from Nikolai Kondrashov <nikolai.kondrashov@xxxxxxxxxx> --- Hi Soumya, Jakub, Here's my corrected package and .spec file. Source RPM: https://github.com/Scribery/tlog/releases/download/v2/tlog-2-1.fc22.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13595353 COPR build: https://copr.fedorainfracloud.org/coprs/nkondras/tlog/build/174028/ Changes include: - The .spec file refers to an actual release tarball, available for download. Although rpmlint gets 403 response for some reason (still to be figured out, COPR downloaded the SRPM without a problem from there). NOTE that the source RPM uses md5 digest for compatibility with EPEL5. - Package uses %{buildroot} only. - The .spec file uses %license with a workaround for RHEL6 and older as suggested by Soumya. - Package owns all directories and files it creates now. - The package now builds on EPEL5. There was no complaint during the RPM build about the defattr not being used. - One-space indent removed from package description (was a habitual mistake coming from Debian packaging) I haven't added a license notice to any of the "unknown or generated" files in the licensecheck.txt because those were generated, plain-text documentation files, or otherwise, specifically: tlog-2/COPYING - the license file itself tlog-2/README.md - plain-text documentation for direct human consumption tlog-2/ar-lib - generated file tlog-2/compile - generated file tlog-2/configure - generated file tlog-2/depcomp - generated file tlog-2/doc/log_format.md - plain-text documentation for direct human consumption tlog-2/lib/play_conf_cmd.c - generated source code tlog-2/lib/play_conf_validate.c - generated source code tlog-2/lib/rec_conf_cmd.c - generated source code tlog-2/lib/rec_conf_validate.c - generated source code tlog-2/missing - generated file tlog-2/test-driver - generated file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx