https://bugzilla.redhat.com/show_bug.cgi?id=1324367 --- Comment #1 from Roman Tsisyk <roman@xxxxxxxxxx> --- * Please add %{?python_provide:%python_provide python2-%{srcname}} macro: https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro * It would be nice to enable unit tests in %check as suggested by upstream: > It is HIGHLY recommended that you build and run all unit tests. https://github.com/libkml/libkml/blob/wiki/BuildingAndInstalling.md#running-the-unit-tests https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites * Actually, this library is a fork of original Google library, so you can't call it "Google's reference implementation". It makes sense to re-word %description. >This is Google's reference implementation of OGC KML 2.2. * You can use Source0: https://github.com/libkml/libkml/archive/%{version}/libkml-%{version}.tar.gz instead of Source0: https://github.com/libkml/libkml/archive/%{version}.tar.gz to get libkml-1.3.0.gz archive instead of 1.3.0.tar.gz All other things are OK. -------- +[X]: Package does not contain kernel modules. +[X]: Package contains no static executables. +[X]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. +[X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. +[X]: License field in the package spec file matches the actual license. +[X]: License file installed when any subpackage combination is installed. +[X]: Package must own all directories that it creates. +[X]: %build honors applicable compiler flags or justifies otherwise. +[X]: Package contains no bundled libraries without FPC exception. +[X]: Changelog in prescribed format. +[X]: Sources contain only permissible code or content. +[X]: Package contains desktop file if it is a GUI application. +[X]: Development files must be in a -devel package +[X]: Package uses nothing in %doc for runtime. +[X]: Package consistently uses macros (instead of hard-coded directory names). +[X]: Package is named according to the Package Naming Guidelines. +[X]: Package obeys FHS, except libexecdir and /usr/target. +[X]: Spec file is legible and written in American English. +[X]: Package is not known to require an ExcludeArch tag. +[X]: Python eggs must not download any dependencies during the build process. +[X]: A package which is used by another package via an egg interface should provide egg info. -------- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx