https://bugzilla.redhat.com/show_bug.cgi?id=988667 --- Comment #27 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- There is no need to use fp.o. Any place where you can put the files and they can be downloaded without human help is OK. But the convention is to paste the links, this allows fedora-review to work without the reviewer having to download stuff by hand. Like this: spec: http://snoopy.polonkai.eu/priv/valadoc-rpm/valadoc-0.30-1.fc23.src.rpm srpm: http://snoopy.polonkai.eu/priv/valadoc-rpm/valadoc.spec Your package must build in a pristine build environment, either mock or koji [https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Mock_and_Koji]. Mock is for local builds, and koji is for builds on the Fedora infrastructure. The first is generally faster, but the second requires less resources. Testing your srpm in mock reveals that you need: BuildRequires: libgee-devel BuildRequires: vala After this is added, it fails with: error: File not found: /builddir/build/BUILDROOT/valadoc-0.30-1.fc25.i386/usr/lib/valadoc/drivers/0.30.x/libdriver.so Please investigate! -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx