https://bugzilla.redhat.com/show_bug.cgi?id=1307149 --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13566708 naming: ok sources: ok (mostly) 4d0a704ab73d2c4dafc313ec313362ea 0.1.1.tar.gz 1. SHOULD follow https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags so tarball name could be more legible (ie, be of the form: %{name}-%{version}.tar.gz) 2. license NOT ok, README.md explicitly mentions MIT, so this MUST be: License: MIT $ rpmlint *.src.rpm mkdocs-material.src: W: no-version-in-last-changelog 3. SHOULD follow changelog guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs all of which explicitly include the version-release of the package macros: ok scriptlets: ok (n/a) please fix MUST item 2, and consider addressing SHOULD items 1,3 as well -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx