https://bugzilla.redhat.com/show_bug.cgi?id=1307127 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13566688 naming: ok sources: ok, mostly 49915cecc84ac6ec5846103d503d1163 0.2.0.tar.gz 1. SHOULD follow https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags so tarball name could be more legible (ie, be of the form: %{name}-%{version}.tar.gz) licensing: ok $ rpmlint *.src.rpm mkdocs-bootswatch.src: W: no-version-in-last-changelog 2. SHOULD follow changelog guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs all of which explicitly include the version-release of the package macros: ok scriplets: ok, n/a Fairly simple and clean noarch pkg, only a couple of cosmetic SHOULD items you can consider fixing, but not worth blocking the review. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx