https://bugzilla.redhat.com/show_bug.cgi?id=1319451 --- Comment #2 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- Package Review ============== Issues ====== The LICENSE file should be in the package and marked as %license. Must own the directory /usr/share/maven-poms/mbassador Suggestions =========== Group tag is unnecessary. Upstream should be advised to add a copyright and license notice in a comment at the top of every source file, even though the README and LICENSE files make the copyright and license information clear. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. The LICENSE file should be in the package and marked as %license [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 122 files have unknown license. Detailed output of licensecheck in /home/michich/1319451-mbassador/licensecheck.txt Upstream should be advised to add a copyright and license notice in a comment at the top of every source file, even though the README and LICENSE files make the copyright and license information clear. [!]: License file installed when any subpackage combination is installed. Consequence of a previously mentioned issue. [x]: Package requires other packages for directories it uses. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/maven- poms/mbassador [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mbassador-1.2.4.1-1.fc25.noarch.rpm mbassador-javadoc-1.2.4.1-1.fc25.noarch.rpm mbassador-1.2.4.1-1.fc25.src.rpm mbassador.noarch: W: spelling-error %description -l en_US eventbus -> event bus, event-bus, eventuates mbassador.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub mbassador.noarch: W: no-documentation mbassador.src: W: spelling-error %description -l en_US eventbus -> event bus, event-bus, eventuates mbassador.src: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory mbassador.noarch: W: spelling-error %description -l en_US eventbus -> event bus, event-bus, eventuates mbassador.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub mbassador.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- mbassador-javadoc (rpmlib, GLIBC filtered): javapackages-tools mbassador mbassador (rpmlib, GLIBC filtered): java-headless javapackages-tools Provides -------- mbassador-javadoc: mbassador-javadoc mbassador: mbassador mvn(net.engio:mbassador) mvn(net.engio:mbassador:pom:) osgi(net.engio.mbassador) Source checksums ---------------- https://github.com/bennidi/mbassador/archive/mbassador-1.2.4.1.tar.gz : CHECKSUM(SHA256) this package : 3f6c312209e0e28754f7dda899ae51b2e8987e1a89649df4114eb0d0a28e84b8 CHECKSUM(SHA256) upstream package : 3f6c312209e0e28754f7dda899ae51b2e8987e1a89649df4114eb0d0a28e84b8 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1319451 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx