https://bugzilla.redhat.com/show_bug.cgi?id=1322168 --- Comment #6 from Honggang LI <honli@xxxxxxxxxx> --- (In reply to Michal Schmidt from comment #5) > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/include/infiniband, > /etc/rdma Own all directories that it creates. > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ibacm- > devel > -Requires: %{name} = %{version}-%{release} +Requires: %{name}%{?_isa} = %{version}-%{release} > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/include/infiniband, > /etc/rdma > /usr/include/infiniband is already owned by multiple packages, > so ibacm can just own it too. > /etc/rdma is owned by the rdma package. ibacm should either co-own > the directory or have "Requires: rdma". ibacm dose not need te rdma package to be present to function properly, so co-owning directory "/etc/rdma". > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ibacm- > devel , ibacm-debuginfo > ibacm-devel should use an arch-specific dependency (add %{?_isa}) Fixed. > [!]: Packages should try to preserve timestamps of original installed > files. > Could call 'install' with '-p' in the spec to preserve the timestamp of > ibacm.service. ibacm_opts.cfg is generated at build time. -install -D -m 644 ibacm_opts.cfg %{buildroot}%{_sysconfdir}/rdma/ibacm_opts.cfg -install -D -m 644 %{SOURCE1} %{buildroot}%{_unitdir}/ibacm.service +install -D -p -m 644 ibacm_opts.cfg %{buildroot}%{_sysconfdir}/rdma/ibacm_opts.cfg +install -D -p -m 644 %{SOURCE1} %{buildroot}%{_unitdir}/ibacm.service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx