https://bugzilla.redhat.com/show_bug.cgi?id=1302904 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Comments about the spec file: - Group can be dropped - %_pkgdocdir is now always defined, you can drop the compat define - Use %autosetup - Drop %clean - Drop "rm -rf %{buildroot}" - For heavens' sake, replace %{__mkdir} with mkdir, %{__install} with install, and so on. - Use proper systemd scriptlets [https://fedoraproject.org/wiki/Packaging:Scriptlets#Scriptlets] - Drop defattr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx