https://bugzilla.redhat.com/show_bug.cgi?id=1323442 --- Comment #4 from Yaozhong Ge <neilgechn@xxxxxxxxx> --- (In reply to gil cattaneo from comment #2) > Hi > there are more prebuilt libraries, and they must be removed > using: > find . -name "*.class" -delete > find . -name "*.jar" -delete > must be removed also: > BuildRoot: %{_tmppath}/%{name}-%{version}-build > field Group > %defattr(-,root,root,-) > You must use make %{?_smp_mflags} instead of make %{?jobs:-j%jobs} > You must use %license macro for LICENSE file > You must use rpm macros instead of hardcoding the directories e.g. > %{_javadir}/XtreemFS.jar > You must use: > Requires: java-headless instead of Requires: jre >= 1.6.0 > or add a/some comment/s, in the spec file, why is necessary jre > You must use: License: BSD instead of License: BSD-3-Clause Thanks your comments. I tried to fix these problems in the spec file. Everything works except removing "*.jar" prebuilt libraries. There are 11 prebuilt libraries in the source package. Most of them can be found in the packages which are currently available in Fedora. Two of them have source available in Github which is fine as they can be contained as "Source1". However, there are still two prebuilt libraries ("jdmkrt.jar" and "jdmktk.jar") necessary during package builing but cannot be compiled from source."jdmkrt.jar" and "jdmktk.jar" comes from OpenDMK. They are necessary to provide SNMP support for status monitor in XtreemFS. And they can't be build from sources without sourceless "binary plug" which is non-free and unmaintained since 2007. (issue is still open on Github: https://github.com/xtreemfs/xtreemfs/issues/309) I am afraid if I make "jdmkrt.jar" and "jdmktk.jar" be compiled during building package, it may against the Fedora Packaging Guidelines. I spent 11 hours trying to separate SNMP support from XtreemFS in order to let this package following Fedora Packaging Guidelines. Unfortunately, I am not familiar with java and I can't make it be possible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx