Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: mutt https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226167 ------- Additional Comments From mlichvar@xxxxxxxxxx 2007-06-25 12:38 EST ------- Thanks for looking at this. (In reply to comment #1) > * maybe you could use gpgme? What would be the advantage of including support for gpgme? It brings additional runtime dependencies, so it has to be really useful :). > * also maybe it could be nice to enable mixmailer the day it enters > fedora When mixmaster is in Fedora, I'll consider it. > * the lynx BuildRequires in my opinion deserves a comment Ok. > * I think that htmlview would be a better Requires than webclient, > that way mutt may be installed without webclient and at the same > time there is more chance that an html viewer will be selected > if one is installed Hm, htmlview depends on redhat-menus. I'd prefer to remove the webclient dependency and not depend on any external application beside sendmail and urlview (and perl from smime_keys). If user hasn't installed a browser, I think it's ok that s/he won't be able to start a browser from mutt. And maybe even the sendmail dependency can be removed since mutt has an smtp client compiled in. > * I am not completly convinced that it is right to have urlview > shipped with mutt. In the mutt documentation it is flagged as > being external. One could imagine people wanting urlview without > mutt. And there could also be people wanting mutt without urlview, > although I wouldn't find it abnormal if mutt depended on urlview Ok, good point, urlview should be packaged separately. > * the second paragraph of the %description seems a bit strange to > me. It seems more confusing than explaining to me, and it seems > to describe mutt more or less as the default text client mail which > seems a bit hard for newcommers to me -- although I don't know what > alternatives exist. Ok, will be removed. > * Maybe /etc/Muttrc may be made %config and not %config(noreplace) > since there is Muttrc.local? I'm not sure it's a good idea, I'd prefer to keep it as noreplace. Users can have /etc/Muttrc configured and ignore /etc/Muttrc.local. > * The XTERM path in url_handler.sh is wrong. I don't think xterm > should be a dependency of urlview, since it would imply getting in > X libs which shouldn't be required in case of mutt/urlview in my > opinion. I'll fix the path. If xterm isn't installed, the application will be started in current terminal, so no need for the dependency. > * What do you think about giving as a Requires of urlview an > application for all of the categories (https, http, mailto, > gopher, ftp)? It is not necessarily a good idea, but maybe > something to think about. I'd prefer to not depend on anything, but I'm open to suggestions :). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review